Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: wrap log.Println in cmd with verbose check #399

Merged
merged 2 commits into from Jan 16, 2022
Merged

chore: wrap log.Println in cmd with verbose check #399

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8c44bc
chore: wrap log.Println in cmd with verbose check
Dec 23, 2021
f195861
Merge branch 'master' into remove_log_print_from_cmd
natefinch Jan 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion sh/cmd.go
View file
Open in desktop
Expand Up @@ -137,7 +137,10 @@ func run(env map[string]string, stdout, stderr io.Writer, cmd string, args ...st
for i := range args {
quoted = append(quoted, fmt.Sprintf("%q", args[i]));
}
log.Println("exec:", cmd, strings.Join(quoted, " "))
// To protect against logging from doing exec in global variables
if mg.Verbose() {
log.Println("exec:", cmd, strings.Join(quoted, " "))
}
err = c.Run()
return CmdRan(err), ExitStatus(err), err
}
Expand Down