Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow mage:import alias to be defined for multiple imports #398

Merged

Conversation

viktorvoltaire
Copy link
Contributor

@viktorvoltaire viktorvoltaire commented Dec 22, 2021

When testing this locally, I haven't been able to trigger any collisions that isnt already flagged by the existing sanity checks. So far everything has just worked as expected, all existing tests are passing.

Documentation wise, I couldnt find anything that actually specifies that the an import alias needs to be unique, so I dont feel we need to add something there

@viktorvoltaire
Copy link
Contributor Author

viktorvoltaire commented Dec 23, 2021

@natefinch @mirogta

@mirogta
Copy link
Member

mirogta commented Dec 23, 2021

@viktorvoltaire wow, nice one, why hadn't I think about this one? :-)

Looks good.

Documentation wise: Now I wonder if you have a specific real use case where this would help you and it might me beneficial for others to explain this use case and actually mention when/how this can be used?

@viktorvoltaire
Copy link
Contributor Author

viktorvoltaire commented Dec 23, 2021

Documentation wise: Now I wonder if you have a specific real use case where this would help you and it might me beneficial for others to explain this use case and actually mention when/how this can be used?

@mirogta We use the namespaces to group commands, to make it easier to identify. For us it makes sense that imports from different packages should be able to be grouped together. I actually thought that this was possible before the issue showed itself for me :) Hence why I think the documentation is good as it is

@viktorvoltaire
Copy link
Contributor Author

@natefinch what do you think?

Copy link
Member

@natefinch natefinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this!

@natefinch natefinch merged commit 0873a9b into magefile:master Jan 16, 2022
scottames pushed a commit to scottames/cmder that referenced this pull request Apr 22, 2023
….0 (#6)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/magefile/mage](https://togithub.com/magefile/mage) |
require | minor | `v1.11.0` -> `v1.14.0` |

---

### Release Notes

<details>
<summary>magefile/mage</summary>

###
[`v1.14.0`](https://togithub.com/magefile/mage/releases/tag/v1.14.0): -
Faster Than Ever

[Compare
Source](https://togithub.com/magefile/mage/compare/v1.13.0...v1.14.0)

#### What's Changed

- give props to netlify on the main page by
[@&#8203;natefinch](https://togithub.com/natefinch) in
[magefile/mage#410
- Update site to build with newer hugo by
[@&#8203;perrito666](https://togithub.com/perrito666) in
[magefile/mage#411
- bring docs for use of directives up to date by
[@&#8203;efd6](https://togithub.com/efd6) in
[magefile/mage#407
- add blog post about v1.13 by
[@&#8203;natefinch](https://togithub.com/natefinch) in
[magefile/mage#412
- fix author links by
[@&#8203;natefinch](https://togithub.com/natefinch) in
[magefile/mage#413
- Add variadic support to mg.F by
[@&#8203;perj](https://togithub.com/perj) in
[magefile/mage#402
- feat: rename templated imports to avoid collisions by
[@&#8203;ladydascalie](https://togithub.com/ladydascalie) in
[magefile/mage#421
- Website: fixing typos by
[@&#8203;deining](https://togithub.com/deining) in
[magefile/mage#429
- refactor(listGoFiles): remove go list dependency by
[@&#8203;jaredallard](https://togithub.com/jaredallard) in
[magefile/mage#440
- doc: add MacPorts install info by
[@&#8203;herbygillot](https://togithub.com/herbygillot) in
[magefile/mage#419

#### New Contributors

- [@&#8203;efd6](https://togithub.com/efd6) made their first
contribution in
[magefile/mage#407
- [@&#8203;perj](https://togithub.com/perj) made their first
contribution in
[magefile/mage#402
- [@&#8203;ladydascalie](https://togithub.com/ladydascalie) made their
first contribution in
[magefile/mage#421
- [@&#8203;deining](https://togithub.com/deining) made their first
contribution in
[magefile/mage#429
- [@&#8203;jaredallard](https://togithub.com/jaredallard) made their
first contribution in
[magefile/mage#440
- [@&#8203;herbygillot](https://togithub.com/herbygillot) made their
first contribution in
[magefile/mage#419

**Full Changelog**:
magefile/mage@v1.13.0...v1.14.0

###
[`v1.13.0`](https://togithub.com/magefile/mage/releases/tag/v1.13.0): -
Magefiles Directory and more!

[Compare
Source](https://togithub.com/magefile/mage/compare/v1.12.1...v1.13.0)

#### What's Changed

- feat: allow mage:import alias to be defined for multiple imports by
[@&#8203;viktorvoltaire](https://togithub.com/viktorvoltaire) in
[magefile/mage#398
- chore: wrap log.Println in cmd with verbose check by
[@&#8203;viktorvoltaire](https://togithub.com/viktorvoltaire) in
[magefile/mage#399
- Detect deps that have already been invoked by
[@&#8203;carolynvs](https://togithub.com/carolynvs) in
[magefile/mage#346
- Replace godoc.org URLs by
[@&#8203;JamieEdge](https://togithub.com/JamieEdge) in
[magefile/mage#342
- Add magefiles directory support by
[@&#8203;perrito666](https://togithub.com/perrito666) in
[magefile/mage#405

#### New Contributors

- [@&#8203;viktorvoltaire](https://togithub.com/viktorvoltaire) made
their first contribution in
[magefile/mage#398
- [@&#8203;carolynvs](https://togithub.com/carolynvs) made their first
contribution in
[magefile/mage#346
- [@&#8203;JamieEdge](https://togithub.com/JamieEdge) made their first
contribution in
[magefile/mage#342
- [@&#8203;perrito666](https://togithub.com/perrito666) made their first
contribution in
[magefile/mage#405

**Full Changelog**:
magefile/mage@v1.12.1...v1.13.0

###
[`v1.12.1`](https://togithub.com/magefile/mage/releases/tag/v1.12.1): -
Second Verse, Same as the First

[Compare
Source](https://togithub.com/magefile/mage/compare/v1.12.0...v1.12.1)

This is a copy of v1.12.0 ... nothing has changed. However, there was an
initial v1.12.0 that was created accidentally, and then deleted, and
it's causing some go proxies to complain. So hopefully this will fix
that.

#### Changelog

- [`2f1ec40`](https://togithub.com/magefile/mage/commit/2f1ec40) ci:
migrate from travis to github action
([#&#8203;391](https://togithub.com/magefile/mage/issues/391))
- [`fe9f942`](https://togithub.com/magefile/mage/commit/fe9f942)
evidently goreleaseer has changed in the last 4 years :)
([#&#8203;394](https://togithub.com/magefile/mage/issues/394))
- [`fd5011e`](https://togithub.com/magefile/mage/commit/fd5011e) Fix the
rollback mechanism for tags during a release
([#&#8203;392](https://togithub.com/magefile/mage/issues/392))
- [`404c119`](https://togithub.com/magefile/mage/commit/404c119)
sh.run(): quoted strings before join
([#&#8203;306](https://togithub.com/magefile/mage/issues/306))
- [`0c5affe`](https://togithub.com/magefile/mage/commit/0c5affe) Add
asdf installation instructions to docs
([#&#8203;383](https://togithub.com/magefile/mage/issues/383))
- [`e84bbc1`](https://togithub.com/magefile/mage/commit/e84bbc1)
[#&#8203;288](https://togithub.com/magefile/mage/issues/288) add brew
and scoop install to docs
([#&#8203;376](https://togithub.com/magefile/mage/issues/376))
- [`80953f7`](https://togithub.com/magefile/mage/commit/80953f7)
[#&#8203;378](https://togithub.com/magefile/mage/issues/378) bump
travisci go16
([#&#8203;379](https://togithub.com/magefile/mage/issues/379))
- [`dd94424`](https://togithub.com/magefile/mage/commit/dd94424) Create
issue templates
([#&#8203;374](https://togithub.com/magefile/mage/issues/374))
- [`d9e2e41`](https://togithub.com/magefile/mage/commit/d9e2e41) fix:
deterministic compiled mainfile
([#&#8203;348](https://togithub.com/magefile/mage/issues/348))
- [`4cf3cfc`](https://togithub.com/magefile/mage/commit/4cf3cfc) make -h
work with imported targets
([#&#8203;335](https://togithub.com/magefile/mage/issues/335))
- [`de7ca6c`](https://togithub.com/magefile/mage/commit/de7ca6c) fix
test for go 1.16
([#&#8203;330](https://togithub.com/magefile/mage/issues/330))

###
[`v1.12.0`](https://togithub.com/magefile/mage/releases/tag/v1.12.0): -
Small Fixes

[Compare
Source](https://togithub.com/magefile/mage/compare/v1.11.0...v1.12.0)

This is our first release in a while, and nothing major is added, but
some small fixes have gone out, like making the mainfile deterministic
and making sure we can use -h with imported targets.

#### Changelog

- [`2f1ec40`](https://togithub.com/magefile/mage/commit/2f1ec40) ci:
migrate from travis to github action
([#&#8203;391](https://togithub.com/magefile/mage/issues/391))
- [`fe9f942`](https://togithub.com/magefile/mage/commit/fe9f942)
evidently goreleaseer has changed in the last 4 years :)
([#&#8203;394](https://togithub.com/magefile/mage/issues/394))
- [`fd5011e`](https://togithub.com/magefile/mage/commit/fd5011e) Fix the
rollback mechanism for tags during a release
([#&#8203;392](https://togithub.com/magefile/mage/issues/392))
- [`404c119`](https://togithub.com/magefile/mage/commit/404c119)
sh.run(): quoted strings before join
([#&#8203;306](https://togithub.com/magefile/mage/issues/306))
- [`0c5affe`](https://togithub.com/magefile/mage/commit/0c5affe) Add
asdf installation instructions to docs
([#&#8203;383](https://togithub.com/magefile/mage/issues/383))
- [`e84bbc1`](https://togithub.com/magefile/mage/commit/e84bbc1)
[#&#8203;288](https://togithub.com/magefile/mage/issues/288) add brew
and scoop install to docs
([#&#8203;376](https://togithub.com/magefile/mage/issues/376))
- [`80953f7`](https://togithub.com/magefile/mage/commit/80953f7)
[#&#8203;378](https://togithub.com/magefile/mage/issues/378) bump
travisci go16
([#&#8203;379](https://togithub.com/magefile/mage/issues/379))
- [`dd94424`](https://togithub.com/magefile/mage/commit/dd94424) Create
issue templates
([#&#8203;374](https://togithub.com/magefile/mage/issues/374))
- [`d9e2e41`](https://togithub.com/magefile/mage/commit/d9e2e41) fix:
deterministic compiled mainfile
([#&#8203;348](https://togithub.com/magefile/mage/issues/348))
- [`4cf3cfc`](https://togithub.com/magefile/mage/commit/4cf3cfc) make -h
work with imported targets
([#&#8203;335](https://togithub.com/magefile/mage/issues/335))
- [`de7ca6c`](https://togithub.com/magefile/mage/commit/de7ca6c) fix
test for go 1.16
([#&#8203;330](https://togithub.com/magefile/mage/issues/330))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/scottames/cmder).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS41Ny4wIiwidXBkYXRlZEluVmVyIjoiMzUuNTcuMCJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants