Fix dependency error propagation by replaying the panic #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-palchikov
changed the title
arschles
previously approved these changes
Oct 1, 2021
a-palchikov
force-pushed
the
dima/371-racy-deps
branch
from
14708d6
to
4ebcbaa
Compare
|
I've been hit with this issue a couple of times, @natefinch do you think it need more work before being merged in? |
time (*onceFun).run is invoked. Fixes magefile#371.
a-palchikov
force-pushed
the
dima/371-racy-deps
branch
from
493d9db
to
58db674
Compare
|
Let me look at this tonight. I'll make time for it. Sorry for the delay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Persist the panic that a dependency had failed with and replay it each time (*onceFun).run is invoked.
I took the liberty of restructuring
runDepsto be more idiomatic by using channels but let me know if that's beyond the scope.Fixes #371.