Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpcc: Fix potential deadlock in stream Sync #134

Merged
merged 2 commits into from Jun 4, 2022
Merged

rpcc: Fix potential deadlock in stream Sync #134

merged 2 commits into from Jun 4, 2022

Commits on Jun 4, 2022

  1. rpcc: Fix potential deadlock in stream Sync 

    The simplified Conn mutex handling introduced in #74 incorrectly moved
the mutex Unlock to after stream.write. This created the opportunity for
a racy mutex deadlock scenario with simultaneous writes to stream while
`Sync` is being performed.

Due to it's racyness, this was only occasionally caught by
`TestStreamSyncNotifyDeadlock` and evaded detection.
    @mafredri
    mafredri committed Jun 4, 2022
    Copy the full SHA
    6970535 View commit details
    Browse the repository at this point in the history

  2. rpcc: Improve odds of deadlock in TestStreamSyncNotifyDeadlock

    @mafredri
    mafredri committed Jun 4, 2022
    Copy the full SHA
    e1f858d View commit details
    Browse the repository at this point in the history