Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use required v4 in examples #73

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use required v4 in examples #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
683c0b6
Use require v4 in examples
jonasfj May 22, 2015
5eeb5c8
Make tests not rely on undefined (it's invalid JSON)
jonasfj May 22, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 6 additions & 10 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,13 @@ Simply pass a schema to compile it
var validator = require('is-my-json-valid')

var validate = validator({
required: true,
type: 'object',
properties: {
hello: {
required: true,
type: 'string'
}
}
},
required: ['hello']
})

console.log('should be valid', validate({hello: 'world'}))
Expand Down Expand Up @@ -58,7 +57,6 @@ If you want to add your own custom formats pass them as the formats options to t
``` js
var validate = validator({
type: 'string',
required: true,
format: 'only-a'
}, {
formats: {
Expand All @@ -76,7 +74,6 @@ You can pass in external schemas that you reference using the `$ref` attribute a

``` js
var ext = {
required: true,
type: 'string'
}

Expand All @@ -97,11 +94,11 @@ is-my-json-valid supports filtering away properties not in the schema

``` js
var filter = validator.filter({
required: true,
type: 'object',
properties: {
hello: {type: 'string', required: true}
hello: {type: 'string'}
},
required: ['hello'],
additionalProperties: false
})

Expand All @@ -115,14 +112,13 @@ is-my-json-valid outputs the value causing an error when verbose is set to true

``` js
var validate = validator({
required: true,
type: 'object',
properties: {
hello: {
required: true,
type: 'string'
}
}
},
required: ['hello']
}, {
verbose: true
})
Expand Down
4 changes: 2 additions & 2 deletions test/misc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ tape('simple', function(t) {
var validate = validator(schema)

t.ok(validate({hello: 'world'}), 'should be valid')
t.notOk(validate(), 'should be invalid')
t.notOk(validate(null), 'should be invalid')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we keep the previous one as well? would be nice to test both undefined and null

t.notOk(validate({}), 'should be invalid')
t.end()
})
Expand Down Expand Up @@ -111,7 +111,7 @@ tape('array', function(t) {
})

t.notOk(validate({}), 'wrong type')
t.notOk(validate(), 'is required')
t.notOk(validate(null), 'is required')
t.ok(validate(['test']))
t.end()
})
Expand Down