Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catch missing schemas #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

catch missing schemas #46

wants to merge 1 commit into from

Conversation

adrai
Copy link

@adrai adrai commented Mar 23, 2015

something like this

something like this
@mafintosh
Copy link
Owner

shouldn't it be an error if a referenced schema is missing? we should probably just throw here actually (thoughts? @watson @ebdrup)

@adrai
Copy link
Author

adrai commented Mar 23, 2015

error is ok for me :-) just wanted to do like: https://github.com/geraintluff/tv4#missing-schema

@watson
Copy link
Collaborator

watson commented Mar 24, 2015

@adrai normally I would say it's a bug in the schema if a $ref is missing (as opposed to a validation error) and it should therefore throw I guess. But there might be a use-case I'm not considering?

@watson
Copy link
Collaborator

watson commented Mar 24, 2015

Follow up thought: I guess the most important thing is that as a dev I'm not confused about the difference between validation errors and "schema" errors. I know you've created a new property called validate.missing as opposed to validate.errors, but the question is if that's obvious enough? A throw would just make it really obvious. But again, I might not know your use-case.

@adrai
Copy link
Author

adrai commented Mar 24, 2015

For my use case it does not really matter… it’s just important to know if a schema is missing…
If you want you can close this pull request and do it like you prefer ;-) You have the choice :-)

Il giorno 24-mar-2015, alle ore 12:34, Thomas Watson Steen <notifications@github.commailto:notifications@github.com> ha scritto:

Follow up thought: I guess the most important thing is that as a dev I'm not confused about the difference between validation errors and "schema" errors. I know you've created a new property called validate.missing as opposed to validate.errors, but the question is if that's obvious enough? A throw would just make it really obvious. But again, I might not know your use-case.


Reply to this email directly or view it on GitHubhttps://github.com//pull/46#issuecomment-85457944.

@adrai
Copy link
Author

adrai commented Mar 25, 2015

What's the proposed decision?

@daditto
Copy link

daditto commented Mar 27, 2015

I, too, am eagerly waiting for a decision :-)

@adrai
Copy link
Author

adrai commented Jul 31, 2015

What was/is the decision?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants