Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add constant for NXDOMAIN #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

nhnt11
Copy link

@nhnt11 nhnt11 commented Jan 22, 2021

Trivially OR'ing 0x03 to the flags works to set NXDOMAIN in the response header. Exposing a constant for this makes it accessible and obvious.

Trivially OR'ing 0x03 to the flags works to set NXDOMAIN in the response header. Exposing a constant for this makes it accessible and obvious.
@nhnt11 nhnt11 closed this Sep 2, 2021
@nhnt11 nhnt11 reopened this Sep 2, 2021
@silverwind
Copy link
Collaborator

silverwind commented Nov 2, 2021

I think instead of exporting this one rcode, we could instead export the toRcode function to make them all accessible. Maybe name it stringToRcode to also allow the reverse to be cleanly exported as rcodeToString.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants