update doh (and dot) examples #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdnsapi is not working with tls
|
Well apparently I should've mentioned an RFC - see #58 |
|
Sorry, I didn’t see your pull request at the time I got a private email about this. Thanks for contributing. It was my oversight, not your description. |
|
No worries lol. And you're welcome. I know maintaining a project is hard, you can't always respond to everything, and the example code isn't what I'd call "critical". So I appreciate your comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
examples/doh.jsto match Google's current API (see https://developers.google.com/speed/public-dns/docs/doh for details)examples/tls.js. getdnsapi.net resolves to 185.49.141.37, and it looks like an authoritative server (it also appears to not support DNS over TLS).