Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sourcemaps #146

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

fix: sourcemaps #146

wants to merge 8 commits into from

Conversation

KingSora
Copy link
Contributor

@KingSora KingSora commented Nov 4, 2022

This is #143 but working, since #143 was so old I couldn't make it work again...

@KingSora KingSora mentioned this pull request Nov 4, 2022
@KingSora
Copy link
Contributor Author

KingSora commented Nov 4, 2022

@madyankin This is working now.. the snapshot test fails because I'm on windows and the generated sourcemaps have backslashes \ as their paths. Thus the snapshot also has \ as the path separator, but your CI runs on Ubuntu where normal forward slashes / are the path separator... I'm not sure what to do here.. you can remove the snapshot if thats the fastest solution for you

@KingSora
Copy link
Contributor Author

KingSora commented Nov 4, 2022

@madyankin We could fix this by normalizing all the paths from the sourcemap in the test, and then match this normalized version with the snapshot. Is this solution something you would consider or is this too much hassle?

@madyankin
Copy link
Owner

@madyankin We could fix this by normalizing all the paths from the sourcemap in the test, and then match this normalized version with the snapshot. Is this solution something you would consider or is this too much hassle?

Yeah, that can be a solution. Could you also rebase the branch please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants