feat: update ICSS utils to current package #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@madyankin Also if you'd like some help maintaining this, I'd be happy to. I know i'm a random person, but I have a lot of experience in the css-modules tooling. I also know how time consuming OSS is and appreciate you may not have a lot of time to look at this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃憢 Hey there, sorry for the drive-by PR. I've updated the replaceValues function to use the most recent version of this util. The old package redirects to
icss-utilsnow. This isn't just maintenance however, the updated replacer works better and will replace values in selectors, which doesn't work right now. This is relevant to me (the maintainer of astroturf) which depends on this behavior in webpack, and i am trying now to write a compatible Vite version