Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Refactor loader dependencies #119

Closed
wants to merge 4 commits into from
Closed

WIP: Refactor loader dependencies #119

wants to merge 4 commits into from

Commits on Jan 15, 2021

  1. Refactor loader dependencies

    Isolates the file loader so it does no longer depend on the parser.
    This frees the loader to only care aout loading files, which makes it
    easier to inject custom loaders via the provided interface.
    
    Since the loader is now only a single function that is extracted
    immediately, it's been reduced to a function instead of a class.
    RianFuro committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    c2fe1a7 View commit details
    Browse the repository at this point in the history
  2. Update babel dev dependencies

    The previous used version of babel had a bug with transpiling async
    methods on classes. See:
    
    babel/babel#6806
    
    Update of babel dependencies fixes the problem
    RianFuro committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    c272f40 View commit details
    Browse the repository at this point in the history
  3. Cleanup parser

    RianFuro committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    1d1d55b View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2021

  1. Move path resolving logic over to loader

    Since the parser shouldn't have to deal with file system operations, the
    loader plugin now has to provide a unique id for an import, which can
    just be an absolute path for the default implementation.
    RianFuro committed Jan 23, 2021
    Configuration menu
    Copy the full SHA
    0209f35 View commit details
    Browse the repository at this point in the history