Add the CoreFoundation framework
#471
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: - Fix remaining errors in `header-translator` output - Get the rest of the project building and depending on `CoreFoundation` as needed
This refers to parameter names in function-type function parameters, for example in `CFRunLoopObserverCreateWithHandler`
|
Definitely should have added the GNUStep target to my local testing! @madsmtm Is there a way to require some generated code be behind a feature flag? I can easily enough go and add |
|
Just responding to GNUStep question, will look at the rest later. I think you may be able to require the feature flag on functions/methods using a specific type by changing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a recreation of #400, to add the
CoreFoundationframeworkThe steps to produce this were to add the requisite boilerplate, make the changes needed for the generated code to compile, make changes on a per-framework basis for all our existing frameworks to compile, and then to finally fix any remaining errors in the header translator output.
Going commit-by-commit should break this down into those steps nicely, and hopefully there should be nothing particularly controversial about this, though there will likely be some discussion points about specfic details
Only other thing to note is that I still have the same issue I've previously been having with my generated code, so I've
not yet pushed up a submodule change to this PRpushed up the submodule change but expect the CI comparison to fail - I do however plan to start looking into resolving that next