Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve and fix CI #532

Merged
merged 1 commit into from Jan 23, 2024
Merged

Improve and fix CI #532

merged 1 commit into from Jan 23, 2024

Conversation

egeakman
Copy link
Contributor

@egeakman egeakman commented Dec 29, 2023

Updates:

  • Test the installation of the commit/PR (the version we checked out with actions/checkout) instead of testing the default branch of the repo. With this, we can actually test pull requests.
  • Test all commits and PRs regardless of branch name.
  • Add option to dispatch the workflow manually.

@egeakman egeakman changed the title Improve CI Improve and fix CI Jan 5, 2024
@egeakman
Copy link
Contributor Author

Kindly pinging @bozhodimitrov

@bozhodimitrov
Copy link
Collaborator

To be honest, we should use pre-commit's setup entirely to avoid the current mess (which doesn't even include testing on windows at all)

https://github.com/pre-commit/pre-commit/blob/main/.github/workflows/main.yml

But for now, there is no much point for major changes since the owner of this repository is busy and PyPi updates are not possible anyways.

@bozhodimitrov
Copy link
Collaborator

bozhodimitrov commented Jan 21, 2024

Also, I don't think that it's a good idea to allow checks on everything.
When I get back home, I will push some adjustments to your branch and will merge.

@egeakman
Copy link
Contributor Author

Hi, thanks for getting back!

About the owner not being available, I believe that poses a significant drag on the project. The last release on PyPI was about one and a half years ago and that discourages potential contributors from contributing. So, I have a few questions:

If he is, would he consider:

  • Giving full permissions to @bozhodimitrov (or another active maintainer) on this repository
  • Adding @bozhodimitrov (or another active maintainer) to the maintainers list in the project metadata, so you can release on PyPI

If he is not, this project is eligible for the implementation of PEP 541.


Quoting PEP 541:

Reachability

The user of the Package Index is solely responsible for being reachable by the Package Index maintainers for matters concerning projects that the user owns. In every case where contacting the user is necessary, the maintainers will try to do so at least three times, using the following means of contact:

  • the e-mail address on file in the user’s profile on the Package Index;
  • the e-mail address listed in the Author field for a given project uploaded to the Index; and
  • any e-mail addresses found in the given project’s documentation on the Index or on the listed Home Page.

The maintainers stop trying to reach the user after six weeks.

Abandoned projects

A project is considered abandoned when ALL of the following are met:

  • owner not reachable (see Reachability above);
  • no releases within the past twelve months; and
  • no activity from the owner on the project’s home page (or no home page listed).

All other projects are considered active.

Continued maintenance of an abandoned project

If a candidate appears willing to continue maintenance on an abandoned project, ownership of the name is transferred when ALL of the following are met:

  • the project has been determined abandoned by the rules described above;
  • the candidate is able to demonstrate their own failed attempts to contact the existing owner;
  • the candidate is able to demonstrate improvements made on the candidate’s own fork of the project;
  • the candidate is able to demonstrate why a fork under a different name is not an acceptable workaround; and
  • the maintainers of the Package Index don’t have any additional reservations.

Under no circumstances will a name be reassigned against the wishes of a reachable owner.

@egeakman
Copy link
Contributor Author

I can open a separate issue to further discuss the maintenance of this project. Please let me know.

@bozhodimitrov
Copy link
Collaborator

This project is not mine, so I can't discuss such stuff. I am just a volunteer like you and everyone else who wanted to help with the project. Unfortunately people have limited time for such projects and it affects the development. This is not uncommon for the OSS repositories.

I understand your enthusiasm and drive to help, but please keep in mind that maintaining a project is a responsibility. And the bigger project means bigger responsibility.
And I am not talking just for the technical perspective.

So, yes. If you want to raise such issue, go for it.
It is always better to have such stuff separate, so they can be addressed individually and the discussions can be on topic.

Update CI trigger policy

Fix package installation for testing

Co-authored-by: Bozho Dimitrov <1278836+bozhodimitrov@users.noreply.github.com>
@bozhodimitrov bozhodimitrov merged commit 0661082 into madmaze:master Jan 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants