Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added FindHostByCustomIdentifier #138

Merged
merged 2 commits into from Oct 5, 2022
Merged

added FindHostByCustomIdentifier #138

merged 2 commits into from Oct 5, 2022

Conversation

yseto
Copy link
Contributor

@yseto yseto commented Oct 5, 2022

No description provided.

@yseto yseto self-assigned this Oct 5, 2022
Arthur1
Arthur1 reviewed Oct 5, 2022
View reviewed changes
Copy link
Member

@Arthur1 Arthur1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks fine to us. Please check our suggestions about test codes.

hosts_test.go Outdated Show resolved Hide resolved
Arthur1
Arthur1 approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@Arthur1 Arthur1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yseto yseto merged commit 194f7bf into master Oct 5, 2022
@yseto
Copy link
Contributor Author

yseto commented Oct 5, 2022

Thanks for your review.

@yseto yseto deleted the custom-identifier branch October 5, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arthur1 Arthur1 Arthur1 approved these changes

Assignees

@yseto yseto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yseto @Arthur1