Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config_test: Add the case of LoadConfigWithInvalidToml #811

Merged
merged 6 commits into from
Sep 7, 2022
Merged

config_test: Add the case of LoadConfigWithInvalidToml #811

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9f25f4b
test: LoadConfigWithInvalidToml
Sep 5, 2022
5c83ffc
defer -> t.Cleanup
Sep 7, 2022
92d3d5f
don't print error if nil
Sep 7, 2022
3b91f06
git merge upstream/master
Sep 7, 2022
fab09de
go fmt
Sep 7, 2022
5072d8f
delete don't need t.Cleanup
Sep 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
62 changes: 41 additions & 21 deletions config/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ func TestLoadConfig(t *testing.T) {
if err != nil {
t.Errorf("should not raise error: %v", err)
}
defer os.Remove(tmpFile.Name())
t.Cleanup(func() { os.Remove(tmpFile.Name()) })

config, err := LoadConfig(tmpFile.Name())
if err != nil {
Expand Down Expand Up @@ -115,7 +115,7 @@ func TestLoadConfigWithHostStatus(t *testing.T) {
if err != nil {
t.Errorf("should not raise error: %v", err)
}
defer os.Remove(tmpFile.Name())
t.Cleanup(func() { os.Remove(tmpFile.Name()) })

config, err := LoadConfig(tmpFile.Name())
if err != nil {
Expand Down Expand Up @@ -152,7 +152,7 @@ func TestLoadConfigWithMountPoint(t *testing.T) {
if err != nil {
t.Errorf("should not raise error: %v", err)
}
defer os.Remove(tmpFile.Name())
t.Cleanup(func() { os.Remove(tmpFile.Name()) })

config, err := LoadConfig(tmpFile.Name())
if err != nil {
Expand All @@ -177,14 +177,34 @@ func TestLoadConfigWithInvalidIgnoreRegexp(t *testing.T) {
if err != nil {
t.Errorf("should not raise error: %v", err)
}
defer os.Remove(tmpFile.Name())
t.Cleanup(func() { os.Remove(tmpFile.Name()) })

_, err = LoadConfig(tmpFile.Name())
if err == nil {
t.Errorf("should raise error: invalid ignore case.")
}
}

var sampleConfigWithInvalidToml = `
apikey = "abcde"

[plugin.metrics.mysql
command = "ruby /path/to/your/plugin/mysql.rb"
`

func TestLoadConfigWithInvalidToml(t *testing.T) {
tmpFile, err := newTempFileWithContent(sampleConfigWithInvalidToml)
if err != nil {
t.Errorf("should not raise error: %v", err)
}
t.Cleanup(func() { os.Remove(tmpFile.Name()) })

_, err = LoadConfig(tmpFile.Name())
if err == nil {
t.Errorf("should raise error: invalid toml case.")
}
}

var sampleConfigWithInvalidMetricsCommand = `
apikey = "abcde"

Expand All @@ -198,11 +218,11 @@ func TestLoadConfigWithInvalidMetricsCommand(t *testing.T) {
if err != nil {
t.Errorf("should not raise error: %v", err)
}
defer os.Remove(tmpFile.Name())
t.Cleanup(func() { os.Remove(tmpFile.Name()) })

_, err = LoadConfig(tmpFile.Name())
if err == nil {
t.Errorf("should raise error: %v", err)
t.Errorf("should raise error: invalid metrics command case.")
}
if !strings.Contains(err.Error(), "should be string or string slice, but int64") {
t.Errorf("should raise error containing type information: %v", err)
Expand All @@ -223,11 +243,11 @@ func TestLoadConfigWithInvalidCheckCommand(t *testing.T) {
if err != nil {
t.Errorf("should not raise error: %v", err)
}
defer os.Remove(tmpFile.Name())
t.Cleanup(func() { os.Remove(tmpFile.Name()) })

_, err = LoadConfig(tmpFile.Name())
if err == nil {
t.Errorf("should raise error: %v", err)
t.Errorf("should raise error: invalid check command case.")
}
if !strings.Contains(err.Error(), "should be string or string slice, but <nil>") {
t.Errorf("should raise error containing type information: %v", err)
Expand Down Expand Up @@ -258,7 +278,7 @@ func TestLoadConfigWithTooLargeCheckMemo(t *testing.T) {
if err != nil {
t.Errorf("should not raise error: %v", err)
}
defer os.Remove(tmpFile.Name())
t.Cleanup(func() { os.Remove(tmpFile.Name()) })

config, err := LoadConfig(tmpFile.Name())

Expand Down Expand Up @@ -294,11 +314,11 @@ func TestLoadConfigWithInvalidMetadataCommand(t *testing.T) {
if err != nil {
t.Errorf("should not raise error: %v", err)
}
defer os.Remove(tmpFile.Name())
t.Cleanup(func() { os.Remove(tmpFile.Name()) })

_, err = LoadConfig(tmpFile.Name())
if err == nil {
t.Errorf("should raise error: %v", err)
t.Errorf("should raise error: invalid metadata command case.")
}
if !strings.Contains(err.Error(), "should be string or string slice, but []interface {}") {
t.Errorf("should raise error containing type information: %v", err)
Expand Down Expand Up @@ -332,7 +352,7 @@ func TestLoadConfigWithCloudPlatform(t *testing.T) {
if err != nil {
t.Errorf("should not raise error: %v", err)
}
defer os.Remove(tmpFile.Name())
t.Cleanup(func() { os.Remove(tmpFile.Name()) })

config, err := LoadConfig(tmpFile.Name())
if err != nil {
Expand All @@ -355,11 +375,11 @@ func TestLoadConfigWithInvalidCloudPlatform(t *testing.T) {
if err != nil {
t.Errorf("should not raise error: %v", err)
}
defer os.Remove(tmpFile.Name())
t.Cleanup(func() { os.Remove(tmpFile.Name()) })

_, err = LoadConfig(tmpFile.Name())
if err == nil {
t.Errorf("should raise error: %v", err)
t.Errorf("should raise error: invalid cloud platform case.")
}
}

Expand All @@ -368,7 +388,7 @@ func TestLoadConfigFile(t *testing.T) {
if err != nil {
t.Errorf("should not raise error: %v", err)
}
defer os.Remove(tmpFile.Name())
t.Cleanup(func() { os.Remove(tmpFile.Name()) })

config, err := loadConfigFile(tmpFile.Name())
if err != nil {
Expand Down Expand Up @@ -605,7 +625,7 @@ command = "this will be overwritten"

configFile, err := newTempFileWithContent(configContent)
assertNoError(t, err)
defer os.Remove(configFile.Name())
t.Cleanup(func() { os.Remove(configFile.Name()) })

includedContent := `
roles = [ "Service:role" ]
Expand Down Expand Up @@ -652,7 +672,7 @@ include = "%s/*.conf"

configFile, err := newTempFileWithContent(configContent)
assertNoError(t, err)
defer os.Remove(configFile.Name())
t.Cleanup(func() { os.Remove(configFile.Name()) })

includedContent := `
apikey = "new-api-key"
Expand Down Expand Up @@ -717,7 +737,7 @@ silent = true
if err != nil {
t.Fatalf("should not raise error: %s", err)
}
defer os.Remove(conff.Name())
t.Cleanup(func() { os.Remove(conff.Name()) })

config, err := loadConfigFile(conff.Name())
assertNoError(t, err)
Expand All @@ -736,7 +756,7 @@ command = ["perl", "-E", "say 'Hello'"]
if err != nil {
t.Fatalf("should not raise error: %s", err)
}
defer os.Remove(conff.Name())
t.Cleanup(func() { os.Remove(conff.Name()) })

config, err := loadConfigFile(conff.Name())
assertNoError(t, err)
Expand Down Expand Up @@ -811,7 +831,7 @@ func main() {
os.Remove(tmpf.Name())
t.Fatalf("should not raise error: %s", err)
}
defer os.Remove(gof)
t.Cleanup(func() { os.Remove(gof) })

conf := fmt.Sprintf(`
apikey = "abcde"
Expand Down Expand Up @@ -839,7 +859,7 @@ env = { "SAMPLE_KEY1" = " foo bar ", "SAMPLE_KEY2" = " baz qux " }
if err != nil {
t.Fatalf("should not raise error: %s", err)
}
defer os.Remove(conff.Name())
t.Cleanup(func() { os.Remove(conff.Name()) })

config, err := loadConfigFile(conff.Name())
assertNoError(t, err)
Expand Down