[plugin-mailq] mailq/postfix: Fix mail queue count regexp capture when it's 1
#1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lufia
reviewed
May 28, 2024
There was a problem hiding this comment.
@yongjiajun Thank you, I think almost ok but please kindly confirm my suggestion
| {mailqCount: 0}, | ||
| {mailqCount: 1}, // #1185 | ||
| } { | ||
| os.Setenv("TEST_MAILQ_COUNT", strconv.Itoa(tc.mailqCount)) |
There was a problem hiding this comment.
[note] In general, Go 1.17 or higher, it would be better to use testing.T.Setenv.
But to keep consistency this use os.Setenv here intentionally because all test cases other than that still use os.Getenv.
Co-authored-by: KADOTA, Kyohei <lufia@users.noreply.github.com>
|
@lufia Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1185
This PR fixes the mail queue count regexp capture for Postfix when there's only 1 item in the mail queue.
Note/Update: The tests in the package modified are passing as I've tested them locally.