Fix TestPlatform.ObjectModel reference

[mikeblakeuk]

Using net 4.7.2, dotnet test
Given we use
AppDomain.CurrentDomain.GetAssemblies();
The TestAdapter has a Machine TestAdapter 2.10.1 references v11 of VS Object Model.
This throws:

System.IO.FileNotFoundException: [ System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.VisualStudio.TestPlatform.ObjectModel, Version=11.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified. File name: 'Microsoft.VisualStudio.TestPlatform.ObjectModel, Version=11.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' at System.Reflection.RuntimeAssembly.GetExportedTypes(RuntimeAssembly assembly, ObjectHandleOnStack retTypes) at System.Reflection.RuntimeAssembly.GetExportedTypes()

This ONLY happens when using dotnet / vstest console, not within the IDE

We can now remove net452

(Mono.Cecil can always be included to make the packaging logic easier)

[robertcoltheart]

1. We can't just remove net452, as that's a breaking change. Long term we want to go there, but that's a 2.0 thing.
2. I ran the scenario you described above, but I'm not seeing the same error. Can you link to a repo to help reproduce this bug, or attach a solution please?

[mikeblakeuk]

Remove the Microsoft.VisualStudio.TestPlatform.ObjectModel.dll

I don't think it's a fair test.

Microsoft.VisualStudio.TestPlatform.ObjectModel.dll may or may not exist.

For our test csproj, we add a reference to

    <PackageReference Include="Machine.Specifications" Version="1.1.0-beta.3" />
    <PackageReference Include="Machine.Specifications.Runner.VisualStudio" Version="2.11.0" />
    <PackageReference Include="Machine.Specifications.Should" Version="1.0.0" />
    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.9.4" />

But the Microsoft.NET.Test.Sdk doesn't copy the Microsoft.VisualStudio.TestPlatform.ObjectModel.dll in

so DevOps / dotnet test fails

[robertcoltheart]

This is by design, the ObjectModel dll is part of the dotnet test harness and doesn't need to be present for the runner to function. This sounds very similar to the xunit issue over here xunit/xunit#1852 and is a problem when a test inadvertently loads the MSpec runner dll.

[mikeblakeuk]

It is related. We could add catch (FileNotFoundException e) but that feels wrong.
Why do we even reference version v11 in our stuff?
We are using v16 of the SDK so it feels like v11 shouldn't even be referenced at all.

[robertcoltheart]

No, it isn't wrong to catch FileNotFoundException, in fact its exactly how NFluent handled this issue. See NFluent/NFluent@63fb9aa#diff-f978bb23b907c755624ea04fe54ca021e22c9c0e3f6e4c701c176a72509c7fd8R96

V11 is used for backwards compatibility, since we are still supporting .net4 versions.

[mikeblakeuk]

They added it in the test library.
Ours is in production code, not test code.
net472 can use v16 instead of v11. hence the change

[mikeblakeuk]

Just for info, this would fix the Assembly load issue.

[mikeblakeuk]

Think this is ready now

[mikeblakeuk]

Amazing, thank you