Add constants for n_types when N_STAB field is being used #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willglynn
reviewed
Apr 13, 2018
There was a problem hiding this comment.
This looks a lot like /usr/include/mach-o/stab.h, and seems in scope here. I like it. 👍
Having said that, I also see a definition for N_PC, which I know nothing about but which seems to be another symbol type. Was it excluded intentionally? If not, should it be included in in goblin too?
|
The reference that I was using didn't include N_PC or N_AST. I've now added them. |
willglynn
approved these changes
Apr 13, 2018
|
Merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.