PE: Support multiple debug directories and VCFeature metadata #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4b
requested changes
Apr 21, 2024
| Ok(idd) | ||
| let idd_list = (0..entries) | ||
| .map(|i| { | ||
| let entry = offset + i * core::mem::size_of::<ImageDebugDirectory>(); |
| @@ -127,60 +145,119 @@ pub struct CodeviewPDB70DebugInfo<'a> { | |||
| } | |||
|
|
|||
| impl<'a> CodeviewPDB70DebugInfo<'a> { | |||
| pub fn parse(bytes: &'a [u8], idd: &ImageDebugDirectory) -> error::Result<Option<Self>> { | |||
| pub fn parse(bytes: &'a [u8], idd: &Vec<ImageDebugDirectory>) -> error::Result<Option<Self>> { | |||
There was a problem hiding this comment.
this should take a &[ImageDebugDirectory] to be more idiomatic rust
| Self::parse_with_opts(bytes, idd, &options::ParseOptions::default()) | ||
| } | ||
|
|
||
| pub fn parse_with_opts( | ||
| bytes: &'a [u8], | ||
| idd: &ImageDebugDirectory, | ||
| idd: &Vec<ImageDebugDirectory>, |
| } | ||
|
|
||
| impl<'a> VCFeatureInfo { | ||
| pub fn parse(bytes: &'a [u8], idd: &Vec<ImageDebugDirectory>) -> error::Result<Option<Self>> { |
|
|
||
| pub fn parse_with_opts( | ||
| bytes: &'a [u8], | ||
| idd: &Vec<ImageDebugDirectory>, |
| pub struct DebugData<'a> { | ||
| pub image_debug_directory: ImageDebugDirectory, | ||
| pub image_debug_directories: Vec<ImageDebugDirectory>, |
There was a problem hiding this comment.
do you know if there is a maximum image debug directories possible? if yes, perhaps we should make this an array and put it back to Copy?
There was a problem hiding this comment.
Yes, the maximum entry is defined as 21.
https://github.com/winsiderss/systeminformer/blob/6f97511ad7bb0c8807d99a3151494f55d0e21fc8/phlib/include/mapimg.h#L714
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue #314.
DebugData::image_debug_directory: ImageDebugDirectoryintoVec<ImageDebugDirectory>as someone pointed out in the PE images with multiple debug directory entries not fully supported #314 (comment). So this is to be an breaking change.IMAGE_DEBUG_TYPE_VC_FEATURE(IMAGE_DEBUG_VC_FEATURE_ENTRY) in the debug directory.If anyone have suggestion of making this semantics without breaking the backward compatibility I am open to discuss.