fix doc warnings #395
Merged
fix doc warnings #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
if you would be interested in setting up a CI job for that, if it isn't too difficult, that would be nice; my only major concern would be if the error messages in CI aren't nice/good/helpful, this could increase difficulty for contributors perhaps |
|
release: non-breaking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of these were reported by
cargo doc. (This should probably have a CI job set up to fail on warnings).For the authenticode change, I figured it wasn't really that important to link to the method that the doc is on, so I just deleted that. And for the strtab change, the anchor hash at the end of the url didn't seem to link anywhere relevant?