Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix out of bounds access while parsing AttributeCertificate #368

Merged
merged 2 commits into from May 1, 2023
Merged

Fix out of bounds access while parsing AttributeCertificate #368

merged 2 commits into from May 1, 2023

Conversation

anfedotoff
Copy link
Contributor

Hi!
During our fuzzing campaign we found an oob in AttributeCertificateHeader::parse. I proposed a fix.

RaitoBezarius
RaitoBezarius approved these changes May 1, 2023
View reviewed changes
Copy link
Contributor

@RaitoBezarius RaitoBezarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, I didn't know that &bytes[*current_offset...(*current_offset + cert_size)] could crash, ugh.

m4b
m4b approved these changes May 1, 2023
View reviewed changes
Copy link
Owner

@m4b m4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@m4b m4b merged commit c199eef into m4b:master May 1, 2023
6 checks passed
@m4b
Copy link
Owner

m4b commented May 15, 2023

non-breaking

@m4b
Copy link
Owner

m4b commented Jun 12, 2023

released in 0.7.0, thank you so much for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaitoBezarius RaitoBezarius RaitoBezarius approved these changes

@m4b m4b m4b approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anfedotoff @m4b @RaitoBezarius