fix: Iterate all ImageDebugDirectory entries #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out, a PE file can have more than one ImageDebugDirectory. Thus far, goblin only looks at the very first one, trying to interpret it as a CV record. This code changes that logic to rather iterate over all the entries to find the one that is a CV record. We still only capture a single entry in the `DebugData` for backwards compatibility reasons. In the future we could as well capture all of them.
Swatinem
force-pushed
the
fix/debug-directory
branch
from
fb87790
to
ba65c43
Compare
|
fun fact: I wrote a detailed blog post about how I made this discovery: https://swatinem.de/blog/format-ossification/ |
|
looks like a CI failure? |
m4b
reviewed
Jul 30, 2022
| Ok(DebugData { | ||
| image_debug_directory, | ||
| codeview_pdb70_debug_info, | ||
| image_debug_directory: entries.pop().unwrap(), |
luser
reviewed
Aug 5, 2022
| .collect::<Result<Vec<ImageDebugDirectory>, _>>()?; | ||
|
|
||
| // find the debug directory that references the codeview record | ||
| for (idx, idd) in entries.iter().enumerate() { |
There was a problem hiding this comment.
I know the original code just tries parsing CodeviewPDB70DebugInfo directly, but you should additionally be able to look at the data_type field to see if it is IMAGE_DEBUG_TYPE_CODEVIEW per the MSDN docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out, a PE file can have more than one ImageDebugDirectory.
Thus far, goblin only looks at the very first one, trying to interpret
it as a CV record.
This code changes that logic to rather iterate over all the entries to
find the one that is a CV record.
We still only capture a single entry in the
DebugDatafor backwardscompatibility reasons. In the future we could as well capture all of
them.