New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elf gnu symbol versioning #280
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
0ab34dc
elf.dynamic: Parse DT_VERDEF + DT_VERDEFNUM dynamic tags into Dynamic…
johannst 7a1a6e6
elf.symver: add struct definitions and reading part for .gnu.version_…
johannst dc1e26b
elf.symver: add tests for parsing .gnu.version_r section
johannst 85ed28d
elf.symver: make structs used by user more ergonomic by using usize
johannst de9a4e7
elf.symver: API updates
johannst 61c00ef
elf.symver: add struct definitions and reading part for .gnu.version_…
johannst 753ad13
elf.symver: Use sub-module as feature guard
johannst 8b882af
add tests for parsing .gnu.version_d section
johannst 89697c4
elf.symver: add struct definitions and reading part for .gnu.version …
johannst b472420
elf.symver: add tests for parsing .gnu.version section
johannst fa03ec3
elf.symver: fix clippy warnings
johannst 8bd8bc8
elf.symver: added some convenience methods to Verdef
johannst 097d6e5
elf.symver: apply review feedback
johannst b2d780f
elf.symver: apply review feedback
johannst 7c41301
elf.symver: apply review feedback
johannst 8dad2eb
elf.symver: add doc comments to constants and move field doc comments…
johannst 49d2b38
elf.symver: fix comments in test
johannst 74e6fb0
elf.symver: move cfg guard globally on module
johannst f029db3
elf.symver: apply review feedback
johannst 5bc5c52
elf.symver: apply review feedback
johannst File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a little sad this only needs the
alloc
feature because (iiuc) it creates aStrtab
, which I believe until only recently did not require thealloc
feature either (maybe it still did, I can't remember).Anyway, something we could possibly investigate fixing in the future, but it's not related to this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems
alloc
is also required for a few other items as well, egResult, Error
,Pread
derive,SectionHeader
.You can nicely see it if you run
make api
and remove thealloc
from the cfg guard.