Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix error when alloc, but not endian_fd #273

Merged
merged 1 commit into from May 30, 2021
Merged

build: fix error when alloc, but not endian_fd #273

merged 1 commit into from May 30, 2021

Conversation

dancrossnyc
Copy link
Contributor

See issue #272 for details.

Signed-off-by: Dan Cross cross@gajendra.net

See issue #272 for details.

Signed-off-by: Dan Cross <cross@gajendra.net>
Copy link
Owner

@m4b m4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Probably this was missed in a refactor

@m4b
Copy link
Owner

m4b commented May 30, 2021

Would be nice for someone to go over the features matrix again in case we missed other stuff like this; in particular, i'd also like the warnings which show up for some feature combinations to be fixed someday on all the different invocations, which we test with make api

@m4b m4b merged commit d406a4a into m4b:master May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants