Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix size check for section headers #249

Merged
merged 1 commit into from Jan 19, 2021
Merged

Fix size check for section headers #249

merged 1 commit into from Jan 19, 2021

Conversation

jan-auer
Copy link
Contributor

@jan-auer jan-auer commented Jan 18, 2021 •
edited

The section header size check introduced in #243 compares the virtual memory
address range sh_addr with the physical file size. This leads to a
false-positive invariant violation and fails to parse valid ELF files.

See also m4b/bingrep#28

cc @jackmay

m4b
m4b approved these changes Jan 19, 2021
View reviewed changes
Copy link
Owner

@m4b m4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this!

@m4b m4b merged commit 84062ff into m4b:master Jan 19, 2021
@jan-auer jan-auer deleted the fix/shdr-check-size branch January 19, 2021 07:49
@jan-auer
Copy link
Contributor Author

Super quick turnaround, thanks a bunch @m4b!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4b m4b m4b approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jan-auer @m4b