Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rpaths to MachO #248

Merged
merged 1 commit into from Jan 4, 2021
Merged

Add rpaths to MachO #248

merged 1 commit into from Jan 4, 2021

Conversation

keith
Copy link
Contributor

@keith keith commented Jan 3, 2021

No description provided.

@keith keith marked this pull request as ready for review January 3, 2021 00:42
@keith
Copy link
Contributor Author

keith commented Jan 3, 2021

I'm not super familiar with rust but when I was trying to load these from the public API I couldn't find a way to without access to bytes. Maybe I'm missing something? Otherwise I think everything using LcStr would have to have some public API like this? It doesn't seem like the other load commands, besides those stored in libs have any callers so I'm not sure.

@m4b
Copy link
Owner

m4b commented Jan 4, 2021

@keith thanks for the PR! This looks good to me, I’m surprised the list of rpaths hasn’t been added yet (or complained about as missing before)!

re your question about LcStr and load commands I didn’t follow exactly

@m4b m4b merged commit c1d6838 into m4b:master Jan 4, 2021
@keith keith deleted the ks/add-rpaths-to-macho branch January 4, 2021 22:48
@keith
Copy link
Contributor Author

keith commented Jan 4, 2021

I mean that I think all the load commands that have LcStrs have to have some convenience API like this currently, since otherwise there's no way to fetch that value. Looks to me like that's mostly handled by libs though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants