apply Flake8 and add it to CI

.github/workflows/format.yml

@@ -24,4 +24,4 @@ jobs:
         poetry install
     - name: Run yapf and isort
       run: |
-        poetry run tox -e yapf,isort
+        poetry run tox -e yapf,isort,flake8

gokart/__init__.py

@@ -1,10 +1,10 @@
-from gokart.build import build
-from gokart.info import make_tree_info, tree_info
-from gokart.pandas_type_config import PandasTypeConfig
-from gokart.parameter import ExplicitBoolParameter, ListTaskInstanceParameter, TaskInstanceParameter
-from gokart.run import run
-from gokart.task import TaskOnKart
-from gokart.testing import test_run
-from gokart.tree.task_info import make_task_info_as_tree_str
-from gokart.utils import add_config
-from gokart.workspace_management import delete_local_unnecessary_outputs
+from gokart.build import build  # noqa:F401
+from gokart.info import make_tree_info, tree_info  # noqa:F401
+from gokart.pandas_type_config import PandasTypeConfig  # noqa:F401
+from gokart.parameter import ExplicitBoolParameter, ListTaskInstanceParameter, TaskInstanceParameter  # noqa:F401
+from gokart.run import run  # noqa:F401
+from gokart.task import TaskOnKart  # noqa:F401
+from gokart.testing import test_run  # noqa:F401
+from gokart.tree.task_info import make_task_info_as_tree_str  # noqa:F401
+from gokart.utils import add_config  # noqa:F401
+from gokart.workspace_management import delete_local_unnecessary_outputs  # noqa:F401

gokart/build.py

@@ -1,5 +1,4 @@
 import logging
-import sys
 from logging import getLogger
 from typing import Any, Optional
 

gokart/file_processor.py

@@ -168,7 +168,7 @@ def load(self, file):
 
     def dump(self, obj, file):
         assert isinstance(obj, pd.DataFrame) or isinstance(obj, pd.Series) or isinstance(obj, dict), \
-           f'requires pd.DataFrame or pd.Series or dict, but {type(obj)} is passed.'
+            f'requires pd.DataFrame or pd.Series or dict, but {type(obj)} is passed.'
         if isinstance(obj, dict):
             obj = pd.DataFrame.from_dict(obj)
         obj.to_json(file)

gokart/info.py

@@ -1,6 +1,5 @@
-import warnings
 from logging import getLogger
-from typing import List, NamedTuple, Optional, Set, Tuple
+from typing import List, Optional, Set
 
 import luigi
 

gokart/object_storage.py

@@ -1,9 +1,10 @@
+
 from datetime import datetime
 
 import luigi
 import luigi.contrib.gcs
 import luigi.contrib.s3
-from luigi.format import FileWrapper, Format
+from luigi.format import Format
 
 from gokart.gcs_config import GCSConfig
 from gokart.gcs_zip_client import GCSZipClient

gokart/slack/__init__.py

@@ -1,3 +1,3 @@
-from gokart.slack.event_aggregator import EventAggregator
-from gokart.slack.slack_api import SlackAPI
-from gokart.slack.slack_config import SlackConfig
+from gokart.slack.event_aggregator import EventAggregator  # noqa:F401
+from gokart.slack.slack_api import SlackAPI  # noqa:F401
+from gokart.slack.slack_config import SlackConfig  # noqa:F401

gokart/task.py

@@ -150,7 +150,7 @@ def clone(self, cls=None, **kwargs):
             cls = self.__class__
 
         new_k = {}
-        for param_name, param_class in cls.get_params():
+        for param_name, _ in cls.get_params():
             if param_name in kwargs:
                 new_k[param_name] = kwargs[param_name]
             elif hasattr(self, param_name) and (param_name not in _SPECIAL_PARAMS):

gokart/testing/__init__.py

@@ -1,2 +1,2 @@
-from gokart.testing.check_if_run_with_empty_data_frame import test_run, try_to_run_test_for_empty_data_frame
-from gokart.testing.pandas_assert import assert_frame_contents_equal
+from gokart.testing.check_if_run_with_empty_data_frame import test_run, try_to_run_test_for_empty_data_frame  # noqa:F401
+from gokart.testing.pandas_assert import assert_frame_contents_equal  # noqa:F401

gokart/tree/task_info.py

@@ -1,9 +1,6 @@
 import os
-import warnings
-from dataclasses import dataclass
-from typing import List, Optional, Set
+from typing import List, Optional
 
-import luigi
 import pandas as pd
 
 from gokart.target import make_target
@@ -46,7 +43,7 @@ def make_task_info_as_table(task: TaskOnKart, ignore_task_names: Optional[List[s
         List of task names to ignore.
     Returns
     -------
-    - task_info_table : pandas.DataFrame 
+    - task_info_table : pandas.DataFrame
         Formatted task dependency table.
     """
 

gokart/tree/task_info_formatter.py

@@ -1,7 +1,7 @@
 import typing
 import warnings
 from dataclasses import dataclass
-from typing import Dict, Iterable, List, NamedTuple, Optional, Set, Union
+from typing import Dict, List, NamedTuple, Optional, Set, Union
 
 import luigi
 

gokart/workspace_management.py

@@ -24,7 +24,7 @@ def delete_local_unnecessary_outputs(task: gokart.TaskOnKart):
     necessary_files = set(_get_all_output_file_paths(task))
     unnecessary_files = all_files - necessary_files - log_files
     if len(unnecessary_files) == 0:
-        logger.info(f'all files are necessary for this task.')
+        logger.info('all files are necessary for this task.')
     else:
         logger.info(f'remove following files: {os.linesep} {os.linesep.join(unnecessary_files)}')
     for file in unnecessary_files: