Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yamlfix 217 #219

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Yamlfix 217 #219

wants to merge 3 commits into from

Conversation

babyhuey
Copy link

Fixing yaml from #217

Checklist

  • Add test cases to all the changes you introduce
  • Update the documentation for the changes

@babyhuey
Copy link
Author

yamllint will error because of the line length. On my personal repos using yamllint I set the line length to only be a warning, instead of an error. I can set that up if we wanted as well

@coveralls
Copy link

coveralls commented Jan 31, 2023

Pull Request Test Coverage Report for Build 4056884906

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.794%

Totals Coverage Status
Change from base Build 4052592081: 0.0%
Covered Lines: 484
Relevant Lines: 485

💛 - Coveralls

Copy link
Owner

@lyz-code lyz-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to fix all the yamls! :)

@@ -58,6 +58,7 @@ lint:
pdm run flakeheaven lint src/ tests/
$(isort) --check-only --df
$(black) --check --diff
yamllint .
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use yamlfix --check instead

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doh! Good idea!

on: # yamllint disable-line rule:truthy
push:
branches: [main]
pull_request:
types: [opened, synchronize]
workflow_dispatch:

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line length should be changed by yamlfix too. Look at the docs. Maybe it's a bug that it's not cropping it well

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't feel like debugging the issue with the cropping, you can do it manually, but I wouldn't increase the line length either in yamlfix or in yamllint

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, it must be a bug. I even tried setting that specifically and it did not work

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed the bug and opened a new issue to track it. I'd say it's better to manually fix these comments so that we can merge the PR. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants