Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various minor fixes #145

Merged
merged 2 commits into from
Dec 13, 2019
Merged

Various minor fixes #145

merged 2 commits into from
Dec 13, 2019

Conversation

yuchaoran2011
Copy link
Contributor

  • omitempty is the right tag name. Note the lowercase e.
  • config strings should be camel case, with the first letter lowercase.
  • Updated the example wordcount to use Flink 1.9.1
  • Go version update to 1.13.4.

@yuchaoran2011
Copy link
Contributor Author

I wonder why the lint job failed because make lint ran without errors on my local machine. I'm using Go 1.13.4. Is it a transient error, in which case could an admin trigger a re-run? Or is it something wrong with Travis? Let me know if it's something in the PR that I can fix. Thanks!

@skonto
Copy link

skonto commented Dec 13, 2019 •
edited

This requires the new version for golangci-lint as described here.

@yuchaoran2011
Copy link
Contributor Author

Admins, as @skonto pointed out above, golangci-lint in travis is outdated. Do you think you guys can easily upgrade that? If not, I'll revert the upgrade to Go 1.13.4 to make the build pass.

@mwylde
Copy link
Contributor

mwylde commented Dec 13, 2019

Yeah, for now I would revert the change to 1.13. I'll look into what's required to update golangci-lint.

@yuchaoran2011
Copy link
Contributor Author

@mwylde Thanks! Done. The build is now passing.

mwylde
mwylde approved these changes Dec 13, 2019
View reviewed changes
Copy link
Contributor

@mwylde mwylde left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all these fixes! I'll merge once tests finish.

@mwylde mwylde merged commit 11eec01 into lyft:master Dec 13, 2019
@yuchaoran2011 yuchaoran2011 deleted the fixes branch December 13, 2019 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwylde mwylde mwylde approved these changes

@anandswaminathan anandswaminathan Awaiting requested review from anandswaminathan anandswaminathan is a code owner

@glaksh100 glaksh100 Awaiting requested review from glaksh100

@kumare3 kumare3 Awaiting requested review from kumare3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yuchaoran2011 @skonto @mwylde