Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix publish workflow #309

Merged
merged 5 commits into from Sep 3, 2021
Merged

Fix publish workflow #309

merged 5 commits into from Sep 3, 2021

Conversation

dblock
Copy link
Contributor

@dblock dblock commented Sep 3, 2021

Fixes #305 by using cargo-publish-all which creates a workspace first, then publishes lychee-lib into it, then publishes lychee-bin using what it just published. So now we can increment the version of lychee-lib and lychee-bin to the next iteration which is the code that we have now on master.

This requires a newer version of rust-type-builder with the fix for idanarye/rust-typed-builder#57.

@mre
Copy link
Member

mre commented Sep 3, 2021

Hey that's great, thanks! Your persistence paid of.

@mre mre merged commit f866abe into lycheeverse:master Sep 3, 2021
@dblock
Copy link
Contributor Author

dblock commented Sep 4, 2021

I think the actual publication should also change to use cargo-publish-all to make the publication idempotent, I'll leave this to you.

@mre
Copy link
Member

mre commented Sep 4, 2021

🤔 you have a point there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish workflow fails
3 participants