Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish workflow fails #305

Closed
dblock opened this issue Sep 1, 2021 · 4 comments · Fixed by #309
Closed

Publish workflow fails #305

dblock opened this issue Sep 1, 2021 · 4 comments · Fixed by #309

Comments

@dblock
Copy link
Contributor

dblock commented Sep 1, 2021

Since #225 the publish CI check is failing, which seems to be "by design". This was confusing to me trying to contribute for the first time - I wasn't sure whether I broke something.

Maybe that workflow should be disabled/removed until it can succeed?

@mre
Copy link
Member

mre commented Sep 3, 2021

Yeah I'm not happy with that tbh. We can of course publish lychee-lib whenever we have to do breaking changes, but it would be great if we could still ensure green builds for feature branches.

@dblock
Copy link
Contributor Author

dblock commented Sep 3, 2021

I am still trying to fix it in #304

@dblock
Copy link
Contributor Author

dblock commented Sep 3, 2021

@mre If you know how to fix dtolnay/proc-macro2#298 we'll be in business.

dblock added a commit to dblock/lychee that referenced this issue Sep 3, 2021
dblock added a commit to dblock/lychee that referenced this issue Sep 3, 2021
@mre mre mentioned this issue Sep 3, 2021
3 tasks
@mre mre closed this as completed in #309 Sep 3, 2021
@mre
Copy link
Member

mre commented Sep 4, 2021

Yay! 🌻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants