Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix readme #154

Merged
merged 2 commits into from Aug 10, 2022
Merged

fix readme #154

merged 2 commits into from Aug 10, 2022

Conversation

eryajf
Copy link
Contributor

@eryajf eryajf commented Aug 7, 2022

README.md Show resolved Hide resolved
@eryajf
Copy link
Contributor Author

eryajf commented Aug 8, 2022

I temporarily removed the corresponding instructions and put the correct version into README. At least until better changes are made, what people see through README is available.

@mre mre merged commit d54f290 into lycheeverse:master Aug 10, 2022
@mre
Copy link
Member

mre commented Aug 10, 2022

FYI v1 points to the latest master again.

@tooomm
Copy link
Contributor

tooomm commented Aug 10, 2022

FYI v1 points to the latest master again.

Not sure you got it right. It shows v1.0.0 from December 2020 as the latest now. 🙈

This is trickier than expected, haha.

@eryajf
Copy link
Contributor Author

eryajf commented Aug 11, 2022

Not sure you got it right. It shows v1.0.0 from December 2020 as the latest now. 🙈

I just ran a test with v1 and it worked normally. This is feasible

https://github.com/eryajf/learn-github/runs/7778974334?check_suite_focus=true

@tooomm
Copy link
Contributor

tooomm commented Aug 11, 2022

It works, yes. But the list of releases is messed up now.

There must be another way when you look at other actions that support this.
Maybe a setting in the marketplace?

@tooomm
Copy link
Contributor

tooomm commented Sep 5, 2022

It seems like there are some open questions or confusion still. @mre

FYI v1 points to the latest master again.

@v1 should not target master, but always the newest available v1.*.* release automatically (v1.5.1 currently).
There is @master for targeting master already.

I think it works for peter-evans/create-issue-from-file, maybe @peter-evans himself can help with the correct marketplace and release setup to get moving releases like v1 for the lychee-action as well? I did not find something useful via google. 🙈

Peter, once you release a v4.0.1 version, you do tag it as such and everybody using v4 should automatically start using it. Is there anything to setup in particular to make it work like that (marketplace, repo, releases...)?

@peter-evans
Copy link

I release using the GitHub releases UI and set the version to the full vx.x.x format. I then use git commands to move the major version tag from the previous release commit to the new release. The major version tag is not associated with any specific GitHub release. I manage it manually with git.

@mre
Copy link
Member

mre commented Nov 3, 2022

Just a quick update: it worked. Thanks for the description @peter-evans.

Here's what I did for the latest release:

  • Created a new tag through the Github releases UI
  • Tagged v1 manually on the CLI: git tag -f v1 v1.5.2
  • Pushed the new tag: git push -f origin v1

My original mistake was that I tagged v1 to master, which had a newer commit than the latest point release. As a result it would show up on top of the list. Now that v1 and v1.5.2 point to the same commit v1 wasn't pushed to the top anymore.

@tooomm tooomm mentioned this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants