Usage example Action does not create issue upon finding broken links

[chipzoller]

Hi, thanks for this very nice action! I copied-and-pasted from your Usage instructions to my repo and ran the action. It found a number of broken links but did not create any issue. I see in the action log echo ::set-output name=exit_code::2 but it did not trigger the if: steps.lychee.outputs.exit_code != 0 clause.

[mre]

Yeah I think that part is broken right now.

We expose the lychee exit code as an output parameter:

lychee-action/entrypoint.sh

Line 45 in a520e85

echo ::set-output name=exit_code::$exit_code

However lychee-action doesn't expose this output to other steps outside the composite action.
My guess is that we need add a section like this to action.yml:

outputs:
  exit_code:
    description: "Lychee exit code"
    value: ${{ steps.lychee.outputs.exit_code }}
runs:
  using: "composite"
  steps:
    ...

Maybe we should also change the output name to exit-code to follow the conventions in the Github Actions documentation?

[chipzoller]

Yeah, that set-output command is typically applicable to shell steps which run directly and aren't delegated. You probably need to add a value and then rework the subsequent task.

[mre]

Alright, can you give that one a spin?
#145
Guess it's just a matter of using uses lychee-action@7f80c6985fbe25c9d6255b5592a0aa6c1a1f1ba2 in your pipeline and see if it works. I'm undecided on the id named lychee in the pipeline. Don't know if it has to be globally unique. If so, we should be more explicit and name it something like lychee-cli-run or so to avoid conflicts.

[mre]

I hope this is resolved in master and v1.5.1 now. Gonna close this as resolved.

[chipzoller]

Thanks, sorry for not responding earlier. Will give this a shot!

[eryajf]

@mre Thanks, the v1.5.1 Normal

Can you update README so that those who find this project will not fail in the future?

[mre]

Oh, sorry about that. I'm traveling today. Would you mind sending a pull request if you find the time? 😅

[eryajf]

I 'd love

[eryajf]

come: #154