Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collect stub files recursively when building stub-only package #18

Merged
merged 2 commits into from Nov 14, 2020

Conversation

hoefling
Copy link
Contributor

The reason for this is that setuptools doesn't support globbing in package_data (see pypa/setuptools#1806), so stub files in subpackages will be collected via neither *.pyi nor **/*.pyi.

Please verify the solution using pathlib is viable. In its current form, this PR would restrict building of wheels and installation of source dists on Python>=3.4. The python_requires specifier is not set, but since the current wheels have py3 tag, I assume the solution is fine - if not, I can rewrite it using os.walk or switch to globbing in MANIFEST.in.

Signed-off-by: oleg.hoefling <oleg.hoefling@gmail.com>
@hoefling
Copy link
Contributor Author

hoefling commented Oct 22, 2020

Also, isort>=5 now includes support for configs in pyproject.toml by default, no extras needed - bumped that in tox config.

…probably have support for recusive globbing long before that changes.
@scoder scoder added the bug Something isn't working label Nov 14, 2020
@scoder scoder merged commit 0355f47 into lxml:master Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants