-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix (dave2d) : remove __NOP(); and __BKPT(0); #6228
Conversation
@@ -45,7 +45,7 @@ d2_color lv_draw_dave2d_lv_colour_to_d2_colour(lv_color_t color) | |||
/*Color depth: 8 (A8), 16 (RGB565), 24 (RGB888), 32 (XRGB8888)*/ | |||
switch(LV_COLOR_DEPTH) { | |||
case(8): | |||
__BKPT(0); | |||
LV_ASSERT(1 == 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be reduced to LV_ASSERT(0)
?
@@ -113,7 +113,7 @@ d2_u32 lv_draw_dave2d_lv_colour_fmt_to_d2_fmt(lv_color_format_t colour_format) | |||
break; | |||
|
|||
default: | |||
__BKPT(0); | |||
LV_ASSERT(1 == 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be reduced to LV_ASSERT(0)
?
@@ -129,7 +127,7 @@ void lv_draw_dave2d_triangle(lv_draw_dave2d_unit_t * u, const lv_draw_triangle_d | |||
} | |||
else if(LV_GRAD_DIR_HOR == dsc->bg_grad.dir) { | |||
/* TODO */ | |||
__BKPT(0); | |||
LV_ASSERT(1 == 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be reduced to LV_ASSERT(0)
?
@@ -112,7 +110,7 @@ void lv_draw_dave2d_triangle(lv_draw_dave2d_unit_t * u, const lv_draw_triangle_d | |||
|
|||
if(a1 < a2) { | |||
/* TODO */ | |||
__BKPT(0); | |||
LV_ASSERT(1 == 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be reduced to LV_ASSERT(0)
?
Description of the feature or fix
fix (Dave2D) : Remove __NOP(); from the Dave2D code
Remove ARM __NOP(); from Dave2D code, to make compiling for RX core cleaner
Notes
lv_conf_template.h
run lv_conf_internal_gen.py and update Kconfig.scripts/code-format.py
(astyle version v3.4.12 needs to be installed) and follow the Code Conventions.