Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use platformdirs for jupyter #421

Merged
merged 1 commit into from Nov 9, 2022
Merged

ci: use platformdirs for jupyter #421

merged 1 commit into from Nov 9, 2022

Conversation

JoepVanlier
Copy link
Member

Adds environment variable to acknowledge that we want to use platformdirs to determine which paths to use. Basically they changed how the path lookup is done and added a deprecation warning to notify us about this. See jupyter/jupyter_core#292 for more information.

Adds environment variable to acknowledge that we want to use `platformdirs` to determine which paths to use. See jupyter/jupyter_core#292 for more information.
Copy link
Member

@tobiasjj tobiasjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚴

@JoepVanlier JoepVanlier merged commit 20ac574 into main Nov 9, 2022
@JoepVanlier JoepVanlier deleted the platformdirs branch November 9, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants