chore: disable turbosnap for Chromatic #4133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like it only supports on push events at the moment.
MEsteves22
requested review from
zettca and
plagoa
and removed request for
a team
zettca
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this run, Chromatic failed due to turbo snap. After doing some research, I found out that vite-plugin-turbosnap was needed.
However, after more research (here and here), it seems like turbo snap is not compatible with
pull_requestevents on CI at the moment.Thus, I'm disabling turbo snap until it's compatible with
pull-requestor we decide to change our workflows (in case we really need turbo snap for some reason).