Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing option to cli #91

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: add missing option to cli #91

wants to merge 1 commit into from

Conversation

jmcantrell
Copy link

The main module is already expecting a clear option to be passed to it, but the cli module was not exposing it to the user.

I found this because I was hoping to add the option to disable clearing the screen. Turns out it was already there, just not in cli.js.

I wasn't sure about where the option should be in the list, the description text, or whether to add a short option, so I just added the bare minimum. Feel free to change it to suit your style.

The main module is already expecting a `clear` option to be passed to
it, but the cli module was not exposing it to the user.
@jmcantrell
Copy link
Author

I just realized this option still gets passed even though it's not mentioned in cli.js, so this is really just a documentation issue.

@akauppi
Copy link

akauppi commented Jan 22, 2021

@jmcantrell Is this now moot that sirv has --no-clear option and the author has explicitly told (somewhere) that it's not to be documented. I.e. with the CLI it always clears. Unless you know how to switch it off. :)

I'm fine with that.

@jmcantrell
Copy link
Author

@akauppi As long as I can use --no-clear, I'm not terribly concerned that it's not documented. I just thought the author might be unaware of that. I am curious why it's purposefully not documented though. Do you have any idea or know where the author mentioned it?

@OJFord
Copy link

OJFord commented Mar 1, 2021

@jmcantrell Here: #58 (comment)

I think just out of reluctance for it to exist at all. It is frustrating though, because I don't use sirv that often (i.e. not through work) so almost every time I forget about --no-clear, am annoyed by the 'clear' behaviour, and end up back here about to open an issue only to re-discover #58.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants