Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply publint recommendations #150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Rich-Harris
Copy link
Contributor

Adds a pkg.exports field. Today, if you import sirv in a "type": "module" app, it will import build.js rather than build.mjs. With this change, build.mjs is imported. Not that it actually makes a difference.

@lukeed
Copy link
Owner

lukeed commented Jan 11, 2023

Adding exports is a breaking change on its own. Cutting a new major solely for this does more harm than good, especially since sirv actually works fine in Node ESM (given native ESM interop).

Will include this once there's actually a change in functionality to constitute a sirv@3.x release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants