Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sirv): avoid false-positive on too big range end #147

Merged
merged 3 commits into from Apr 24, 2023
Merged

fix(sirv): avoid false-positive on too big range end #147

merged 3 commits into from Apr 24, 2023

Conversation

dmkret
Copy link
Contributor

@dmkret dmkret commented Nov 4, 2022

Closes #140

@benmccann
Copy link
Contributor

@dmkret is there a test that could be added for this to prevent a regression?

@dmkret
Copy link
Contributor Author

dmkret commented Apr 18, 2023

@benmccann I've added a test and changed incorrect existing

tests/sirv.js Outdated Show resolved Hide resolved
@dmkret
Copy link
Contributor Author

dmkret commented Apr 22, 2023

@benmccann

@benmccann
Copy link
Contributor

@dmkret I don't have merge rights on this repo

@lukeed
Copy link
Owner

lukeed commented Apr 22, 2023

Sorry I’m in the middle of a move. Will look tomorrow or Monday

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (1879a3e) 62.23% compared to head (eb1ccce) 62.23%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #147   +/-   ##
=======================================
  Coverage   62.23%   62.23%           
=======================================
  Files           2        2           
  Lines         143      143           
=======================================
  Hits           89       89           
  Misses         54       54           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lukeed lukeed merged commit 52f5dcf into lukeed:master Apr 24, 2023
5 checks passed
sapphi-red added a commit to sapphi-red/vite-plugin-static-copy that referenced this pull request May 12, 2023
brunoimbrizi pushed a commit to brunoimbrizi/vite-plugin-static-copy that referenced this pull request May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Range request overlap is handled incorrectly
4 participants