Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix esm support and types #57

Merged
merged 1 commit into from Jul 15, 2023
Merged

fix: fix esm support and types #57

merged 1 commit into from Jul 15, 2023

Commits on Nov 1, 2022

  1. fix: fix esm support and types 

    The non-standard `package.json` field `module` was used. This pointed to
a faux ESM file (Uses ESM syntax, but has a `.js` file extension in a
package which doesn’t specify `"type": "module"`.

ESM support was fixed by using the `.mjs` file extension for the ESM
export and defining a proper `exports` field in `package.json.

The types reflected a package that has the `module.exports.default`
field. This was incorrect. The CommonJS types have now been fixed to use
`export =`, which is the correct way to type modules that use
`module.exports` assignments.

Additional types were added for ESM support.
    @remcohaszing
    remcohaszing committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    40a074e View commit details
    Browse the repository at this point in the history