Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump dependencies #44

Closed
wants to merge 2 commits into from
Closed

chore: bump dependencies #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31d0956
chore: bump dependencies
lino-levan Mar 8, 2023
37ac2f8
chore: update readme example
lino-levan Mar 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ import { denoPlugin } from "https://deno.land/x/esbuild_deno_loader@0.6.0/mod.ts

const result = await esbuild.build({
plugins: [denoPlugin()],
entryPoints: ["https://deno.land/std@0.173.0/hash/sha1.ts"],
outfile: "./dist/sha1.esm.js",
entryPoints: ["https://deno.land/std@0.178.0/bytes/mod.ts"],
outfile: "./dist/bytes.esm.js",
bundle: true,
format: "esm",
});
Expand Down
4 changes: 2 additions & 2 deletions deps.ts
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not relevant today, but... TypeScript 5.0 will ship tomorrow, and will include support for export type * (commit).

Whenever Deno updates its TS version to support this new syntax, the following can be rewritten:

Before:

import type * as esbuild from "https://deno.land/x/esbuild@v0.17.11/mod.d.ts";
export type { esbuild };

After:

export type * as esbuild from "https://deno.land/x/esbuild@v0.17.11/mod.d.ts";

Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ export {
fromFileUrl,
resolve,
toFileUrl,
} from "https://deno.land/std@0.173.0/path/mod.ts";
export { basename, extname } from "https://deno.land/std@0.173.0/path/mod.ts";
} from "https://deno.land/std@0.178.0/path/mod.ts";
export { basename, extname } from "https://deno.land/std@0.178.0/path/mod.ts";
Comment on lines 4 to +8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two path exports use the same specifier and can be merged into one statement.

export {
resolveImportMap,
resolveModuleSpecifier,
Expand Down
2 changes: 1 addition & 1 deletion examples/bundle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { denoPlugin } from "../mod.ts";

await esbuild.build({
plugins: [denoPlugin()],
entryPoints: ["https://deno.land/std@0.173.0/bytes/mod.ts"],
entryPoints: ["https://deno.land/std@0.178.0/bytes/mod.ts"],
outfile: "./dist/bytes.esm.js",
bundle: true,
format: "esm",
Expand Down
4 changes: 2 additions & 2 deletions mod_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ test("remote ts", LOADERS, async (esbuild, loader) => {
const res = await esbuild.build({
...DEFAULT_OPTS,
plugins: [denoPlugin({ loader })],
entryPoints: ["https://deno.land/std@0.173.0/collections/without_all.ts"],
entryPoints: ["https://deno.land/std@0.178.0/collections/without_all.ts"],
});
assertEquals(res.warnings, []);
assertEquals(res.errors, []);
Expand Down Expand Up @@ -243,7 +243,7 @@ test("bundle remote imports", LOADERS, async (esbuild, loader) => {
plugins: [denoPlugin({ loader })],
bundle: true,
platform: "neutral",
entryPoints: ["https://deno.land/std@0.173.0/uuid/mod.ts"],
entryPoints: ["https://deno.land/std@0.178.0/uuid/mod.ts"],
});
assertEquals(res.warnings, []);
assertEquals(res.errors, []);
Expand Down
2 changes: 1 addition & 1 deletion test_deps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ export {
assert,
assertEquals,
assertThrows,
} from "https://deno.land/std@0.173.0/testing/asserts.ts";
} from "https://deno.land/std@0.178.0/testing/asserts.ts";