sysusers: add parsing logic #94
Conversation
lucab
force-pushed
the
ups/sysusers-parse
branch
4 times, most recently
from
eebb1b1
to
2c7a4ef
Compare
There was a problem hiding this comment.
(Skimmed) LGTM.
Though are the systemd developers aware of this parser? Its existence may (likely will) require pull requests here as they evolve the format in the future.
In particular if we end up in a situation where e.g. rpm-ostree starts crashing at build time because a newer systemd package uses a new type tag, I think that's going to be a long term problem.
We can mostly mitigate that by having any new sysusers changes done via a PR here and try to respin e.g. rpm-ostree before newer systemd, but longer term I think we're going to need this parser to gracefully handle unknown features.
I think you raised a fair point. Let's rework the parser here to log a warning and proceed on unrecognized line types. |
This adds support for parsing entries from sysusers.d lines. Overall logic is organized around the 'nom' parser-combinator framework. It is now possible to roundtrip configuration entries, loading content from files as well writing back data.
This introduces a specific error kind to detect and recover from sysusers parsing failures due to an invalid type signature. It allows leaving some room for new entry types which could possibly be introduced upstream in the future. Thus, lines with unrecognized signatures are now skipped, and a warning message is logged.
lucab
force-pushed
the
ups/sysusers-parse
branch
from
2c7a4ef
to
17053bb
Compare
|
Added one commit to detect&recover on unknown entry types, let me know if that meets your expectations now. |
|
@cgwalters unless further comments, I'm going ahead and merging this. |
This adds support for parsing entries from sysusers.d lines.
Overall logic is organized around the 'nom' parser-combinator
framework.
It is now possible to roundtrip configuration entries, loading
content from files as well as writing back data.