Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Meson parity #373

Merged
merged 6 commits into from
May 29, 2024
Merged

Implement Meson parity #373

merged 6 commits into from
May 29, 2024

Conversation

amyspark
Copy link
Contributor

@amyspark amyspark commented May 4, 2024

Hi @lu-zero,

This PR tries to implement the necessary bits to support the following Meson conventions:

  • autodetection of libdir under Debian distros
  • installation of PDB symbols under MSVC
  • calling static libraries libfoo.a and import libraries foo.lib under MSVC

The second item is done in a way that allows adding support for other OSes (as what's needed is passing -C split-debuginfo=packed, and this is the default on macOS).

Setting it as draft before testing; will do so later next week, but I wanted to get some early feedback first.

cc @nirbheek

Fixes #279
Fixes #280
Fixes #317

src/install.rs Outdated Show resolved Hide resolved
src/install.rs Outdated Show resolved Hide resolved
src/install.rs Outdated Show resolved Hide resolved
src/install.rs Outdated Show resolved Hide resolved
src/install.rs Outdated Show resolved Hide resolved
src/cli.rs Outdated Show resolved Hide resolved
@amyspark amyspark marked this pull request as ready for review May 14, 2024 17:28
src/target.rs Outdated Show resolved Hide resolved
src/target.rs Outdated Show resolved Hide resolved
@lu-zero lu-zero force-pushed the meson-parity branch 3 times, most recently from 1b46030 to 7b3c02a Compare May 29, 2024 04:52
@lu-zero
Copy link
Owner

lu-zero commented May 29, 2024

I fixed most I could, but I do not have window to fix the last bit.

@lu-zero
Copy link
Owner

lu-zero commented May 29, 2024

Looks like there is some _ vs - ongoing.

@lu-zero lu-zero merged commit 2fc89b3 into lu-zero:master May 29, 2024
14 checks passed
@amyspark amyspark deleted the meson-parity branch May 29, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants