Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to clap-3.1 and cargo-0.61 #255

Merged
merged 5 commits into from Apr 19, 2022
Merged

Update to clap-3.1 and cargo-0.61 #255

merged 5 commits into from Apr 19, 2022

Conversation

lu-zero
Copy link
Owner

@lu-zero lu-zero commented Apr 9, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2022

Codecov Report

Merging #255 (a690e05) into master (3584f2b) will decrease coverage by 2.71%.
The diff coverage is 84.53%.

@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
- Coverage   84.27%   81.56%   -2.72%     
==========================================
  Files          12       12              
  Lines        1819     1833      +14     
==========================================
- Hits         1533     1495      -38     
- Misses        286      338      +52     
Impacted Files Coverage Δ
src/cli.rs 84.27% <77.77%> (-4.28%) ⬇️
src/bin/capi.rs 80.43% <81.81%> (-3.57%) ⬇️
src/bin/cbuild.rs 77.77% <83.33%> (-2.87%) ⬇️
src/bin/cinstall.rs 78.57% <83.33%> (-2.08%) ⬇️
src/bin/ctest.rs 77.77% <83.33%> (-2.87%) ⬇️
src/build.rs 80.39% <100.00%> (-4.43%) ⬇️
src/config.rs 100.00% <100.00%> (ø)
src/install.rs 73.79% <100.00%> (ø)
src/pkg_config_gen.rs 86.85% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3584f2b...a690e05. Read the comment docs.

@lu-zero lu-zero force-pushed the cargo-0.61 branch 3 times, most recently from 41b287d to f0d0d24 Compare April 10, 2022 05:27
@lu-zero
Copy link
Owner Author

lu-zero commented Apr 10, 2022

Sadly a design change decision in clap broke silently quite a bit. clap-rs/clap#3621

@lu-zero lu-zero force-pushed the cargo-0.61 branch 2 times, most recently from bd03b3a to 9250efc Compare April 19, 2022 17:28
@lu-zero lu-zero merged commit e0e0683 into master Apr 19, 2022
@lu-zero lu-zero deleted the cargo-0.61 branch April 19, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants