MWEB Light Client

[hectorchu]

Change Description

Description of change / link to associated issue.

Steps to Test

Steps for reviewers to follow to test the change.

Pull Request Checklist

Testing

• Your PR passes all CI checks.
• Tests covering the positive and negative (error paths) are included.
• Bug fixes contain tests triggering the bug to prevent regressions.

Code Style and Documentation

• The change obeys the Code Documentation and Commenting guidelines, and lines wrap at 80.
• Commits follow the Ideal Git Commit Structure.
• Any new logging statements use an appropriate subsystem and logging level.
• There is a change description in the release notes, or [skip ci] in the commit message for small changes.

📝 Please see our Contribution Guidelines for further guidance.

[losh11]

@hectorchu Is it a good idea to disable this check? The comment mentions that without this, the rescan wouldn't continue unless explictly started that way. Differing behaviour needs to be documented (@losh11).

[hectorchu]

It says you just need to remember to unlock the wallet next time with the recovery window option, which we do do. So its not an issue to allow a shutdown.

[losh11]

@hectorchu in which case is the incorrect rawtx given?

[hectorchu]

For MWEB txns. Because after we've broadcast it we modify the MsgTx to add 'in the clear' MWEB inputs and outputs to the MsgTx, from the MsgTx.Mweb data. So the serialized tx changes. We save the original broadcast serialization in a separate field.