Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phpunit fixes #48

Merged
merged 2 commits into from Jul 7, 2023
Merged

Phpunit fixes #48

merged 2 commits into from Jul 7, 2023

Conversation

ehsan42
Copy link

@ehsan42 ehsan42 commented Mar 18, 2022

replaced with specialized alternatives to assertInternalType()
sebastianbergmann/phpunit#3368

@aspark21
Copy link
Contributor

aspark21 commented Mar 28, 2022

@ChaoticDalo This fixes unit tests for Moodle 3.11+

It would probably worth adding the Github Actions CI for Moodle Plugins - https://moodlehq.github.io/moodle-plugin-ci/
Can probably get the team to implement in a separate merge request if you want?

@aspark21
Copy link
Contributor

can this be merged?

@ChaoticDalo
Copy link
Contributor

Thanks @aspark21 I'll look into this asap.

@ChaoticDalo ChaoticDalo changed the base branch from master to develop July 7, 2023 19:46
@ChaoticDalo ChaoticDalo merged commit 9e5f342 into lsuonline:develop Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants