Commonmarker 1.0 support #1540
Open
Commonmarker 1.0 support #1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes lsegal#1528 Co-Authored-By: Andrew Haines <andrew@haines.org.nz>
Preference for the provider’s highlighting is outside of this PR’s scope.
ParadoxV5
commented
Mar 23, 2024
| @@ -89,6 +89,9 @@ def html_markup_markdown(text) | |||
| :tables, | |||
| :with_toc_data, | |||
| :no_intraemphasis).to_html | |||
| when 'Commonmarker' | |||
| # GFM configs are on by default; use YARD for syntax highlighting | |||
| Commonmarker.to_html(text, plugins: {syntax_highlighter: nil}) | |||
There was a problem hiding this comment.
Suggested change
| Commonmarker.to_html(text, plugins: {syntax_highlighter: nil}) | |
| Commonmarker.to_html(text) |
However, preference for the provider’s highlighting is outside of this PR’s scope.
Testing providers’ implementation is outside of the scope of YARD. I let the backslash line break difference live since that’s probably provider-specific.
ParadoxV5
added a commit
to ParadoxV5/template-ruby-gem
that referenced
this pull request
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Commonmarker(all lower-casems) provider forcommonmarker ~> 1.0.0skiptoraiseto catch this sort of issues in the futureCompleted Tasks
bundle exec rakelocally (if code is attached to PR).