Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lib.fetch types using experimental ts-graft discover mode #100

Merged
merged 1 commit into from Mar 27, 2021

Commits on Mar 22, 2021

  1. fix: lib.fetch types using experimental ts-graft discover mode

    lib.fetch.d.ts includes all type definitions from the dom and
    dom.iterable libs which were reachable from the original cross-fetch
    index.d.ts file:
    
    ```
    git checkout 7b19cda -- index.d.ts
    ```
    
    lib.fetch.d.ts was generated with the following command:
    
    ```
    cat <<EOF > .ts-graftrc.yaml \
    && npx ts-graft@2.0.0-1 \
    && rm .ts-graftrc.yaml \
    grafts:
      - source: index.d.ts
        output: lib.fetch.d.ts
        include:
          - dom
          - dom.iterable
    EOF
    ```
    
    index.d.ts was then updated to its new state and verified with the
    following command:
    
    ```
    npx tsc --lib ES6 index.d.ts
    ```
    
    Issue lquixada#95 was validated as follows:
    
    ```
    cat <<EOF > test.ts \
    && npx tsc --target ES6 --moduleResolution node --noEmit  test.ts \
    && rm test.ts
    import fetch from "./";
    export const customFetch = (
      input: RequestInfo,
      init: RequestInit,
    ): Promise<Response> => {
      let url = "";
      url += input;
      return fetch(url, init);
    };
    EOF
    ```
    
    n.b. consumers must include the dom.iterable lib, which is implied by
    the ES6 target, lest their globals lack the required members defined
    by dom.iterable.
    jstewmon committed Mar 22, 2021
    Copy the full SHA
    e34d41d View commit details
    Browse the repository at this point in the history