Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to node-fetch@3 #118

Closed
jimmywarting opened this issue Nov 10, 2021 · 9 comments
Closed

update to node-fetch@3 #118

jimmywarting opened this issue Nov 10, 2021 · 9 comments

Comments

@jimmywarting
Copy link

Any thoughts on start using node-fetch v3
It's built as ESM only doe...

@lquixada
Copy link
Owner

I've tried using it but it wasn't straight forward to add it to the lib. cross-fetch is CJS.

@jimmywarting
Copy link
Author

any chance that this could be converted to esm as well?

@lquixada
Copy link
Owner

not seeing that on the near future. might reconsider at some point.

@yinzara
Copy link

yinzara commented Nov 16, 2021

Please don't

node-fetch/node-fetch#1263

Sorry @jimmywarting , I still don't think you've given enough of a reason that libraries that are targeted at NodeJS should be making this swap now. We're up to 103 to 15 now.

Additionally, TypeScript 4.5 has now removed the ESM NodeJS support from its feature list so users of TypeScript still have to use some of your crazy work arounds to be able to use ESM only libraries. Hopefully TypeScript 4.6 will have this feature and it'll come soon.
https://www.infoworld.com/article/3637149/typescript-delays-esm-support-for-nodejs.html

@LiangXuehongBJ
Copy link

Hi.
Is there a plan(timeline) to using node-fetch v3?
We are using some other package which uses package cross-fetch as dependency.
But there is an CVE-2022-0235 vulnerability (Medium) detected in node-fetch-2.6.1.tgz.
Thanks.

Vulnerability Details
node-fetch is vulnerable to Exposure of Sensitive Information to an Unauthorized Actor

Publish Date: 2022-01-16

URL: CVE-2022-0235

I've tried using it but it wasn't straight forward to add it to the lib. cross-fetch is CJS.

@jimmywarting
Copy link
Author

fyi v2.x got patched and fixed for security reason for ppl who are stuck with cjs

@imsys
Copy link

imsys commented Jan 22, 2022

To be more specific, it was fixed on 2.6.7
node-fetch/node-fetch@1ef4b56
We just need someone to fix the warning for 2.6.7.

@imsys
Copy link

imsys commented Jan 23, 2022

Update, the warning is fixed for:

Affected versions

>= 3.0.0, < 3.1.1
< 2.6.7

Patched versions

3.1.1
2.6.7

@lquixada
Copy link
Owner

cross-fetch@3.1.5 was released with node-fetch@2.6.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants